Issue 7201043: code review 7201043: exp/locale/collate/tools/colcmp: fixes some discrepanci...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7201043: code review 7201043: exp/locale/collate/tools/colcmp: fixes some discrepanci... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by mpvl

Modified:
12 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

exp/locale/collate/tools/colcmp: fixes some discrepancies between ICU and collate package: ICU requires strings to be in FCD form. Not all NFC strings are in this form, leading to incorrect results. Change to NFD instead.

Patch Set 1 #

Patch Set 2 : diff -r 46418dc3d59d https://go.googlecode.com/hg #

Patch Set 3 : diff -r 46418dc3d59d https://go.googlecode.com/hg #

Patch Set 4 : diff -r 52940b70c0cd https://go.googlecode.com/hg #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/exp/locale/collate/tools/colcmp/colcmp.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/exp/locale/collate/tools/colcmp/gen.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mpvl

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

12 years, 5 months ago (2013-01-23 13:21:11 UTC) #1

mpvl

12 years, 5 months ago (2013-01-30 20:19:08 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=85014abe1574 ***

exp/locale/collate/tools/colcmp: fixes some discrepancies between
ICU and collate package: ICU requires strings to be in FCD form.
Not all NFC strings are in this form, leading to incorrect results.
Change to NFD instead.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7201043

Expand All Messages | Collapse All Messages