Issue 7199047: http issue 63: Generalize MutipartContent so that it can be used to replace MultipartRelatedContent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7199047: http issue 63: Generalize MutipartContent so that it can be used to replace MultipartRelatedContent (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by yanivi

Modified:
11 years, 3 months ago

Reviewers:
rmistry

CC:
ngmiceli, peleyal

Base URL:
https://code.google.com/p/google-http-java-client/

Visibility:
Public.

More Reviews

Description

http issue 63: Generalize MutipartContent so that it can be used to replace MultipartRelatedContent https://code.google.com/p/google-http-java-client/issues/detail?id=63 fix bug in GZipEncoding that closes output stream instead of flushing

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : fix bug in GZipEncoding that closes output stream instead of flushing #

Patch Set 4 : more fixes #

Patch Set 5 : minor #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+485 lines, -15 lines)			Patch
M	findbugs-exclude.xml	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/AbstractHttpContent.java	View		1 chunk	+19 lines, -6 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/GZipEncoding.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpContent.java	View	1 2 3	2 chunks	+11 lines, -0 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpEncoding.java	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
A	google-http-client/src/main/java/com/google/api/client/http/MultipartContent.java	View	1 2 3	1 chunk	+273 lines, -0 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/MultipartRelatedContent.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/StreamingContent.java	View	1 2 3	1 chunk	+5 lines, -3 lines	0 comments	Download
A	google-http-client/src/test/java/com/google/api/client/http/GZipEncodingTest.java	View	1 2 3	1 chunk	+50 lines, -0 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java	View	1 2 3	1 chunk	+44 lines, -0 lines	0 comments	Download
A	google-http-client/src/test/java/com/google/api/client/http/MultipartContentTest.java	View		1 chunk	+67 lines, -0 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/MultipartRelatedContentTest.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages