Issue 7198051: state: relation code cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7198051: state: relation code cleanup

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by fwereade

Modified:
11 years, 3 months ago

Reviewers:
rog, mp+144747, TheMue

Visibility:
Public.

Description

state: relation code cleanup * move RelationUnit into its own file * move RelationUnitSuite into its own file * delete OriginalRelationUnitSuite, which is redundant, apart from... * new RelationUnitSuite.TestReadSettingsErrors, moved from ORUS This change does not affect behaviour. The OriginalRelationUnitSuite is an appendix, left over from the mstate change, and it's now nothing but a burden (apart from the settings error tests that moved to the RelationUnitSuite). https://code.launchpad.net/~fwereade/juju-core/state-relationunit-move/+merge/144747 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: relation code cleanup #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1023 lines, -1560 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/relation.go	View	1	1 chunk	+0 lines, -351 lines	0 comments	Download
M	state/relation_test.go	View	1	2 chunks	+0 lines, -1209 lines	0 comments	Download
A	state/relationunit.go	View	1	1 chunk	+362 lines, -0 lines	0 comments	Download
A	state/relationunit_test.go	View	1	1 chunk	+659 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2013/01/24 16:45:02, fwereade wrote: > Please take a look. LGTM

11 years, 3 months ago (2013-01-24 16:49:26 UTC) #2

fwereade

11 years, 3 months ago (2013-01-25 18:09:27 UTC) #4

*** Submitted:

state: relation code cleanup

* move RelationUnit into its own file
  * move RelationUnitSuite into its own file
  * delete OriginalRelationUnitSuite, which is redundant, apart from...
  * new RelationUnitSuite.TestReadSettingsErrors, moved from ORUS

This change does not affect behaviour. The OriginalRelationUnitSuite is an
appendix, left over from the mstate change, and it's now nothing but a
burden (apart from the settings error tests that moved to the
RelationUnitSuite).

R=rog, TheMue
CC=
https://codereview.appspot.com/7198051

Expand All Messages | Collapse All Messages