Issue 7198050: Remove method calls on invalid "this" pointer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7198050: Remove method calls on invalid "this" pointer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bungeman

Modified:
13 years, 2 months ago

Reviewers:
bsalomon, sheu, senorblanco, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This is a less disruptive version of https://codereview.appspot.com/7201048/ .

Patch Set 2 : Add "this->" qualifier per comments. #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -12 lines)			Patch
	M	src/core/SkRegion.cpp	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
	M	src/core/SkRegionPriv.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

reed1

like, but w/ requested this-> addition. https://codereview.appspot.com/7198050/diff/1/src/core/SkRegion.cpp File src/core/SkRegion.cpp (right): https://codereview.appspot.com/7198050/diff/1/src/core/SkRegion.cpp#newcode91 src/core/SkRegion.cpp:91: void SkRegion::freeRuns() { ...

13 years, 2 months ago (2013-01-24 16:03:37 UTC) #3

bungeman

Added "this->" qualifier for clarity. https://codereview.appspot.com/7198050/diff/1/src/core/SkRegion.cpp File src/core/SkRegion.cpp (right): https://codereview.appspot.com/7198050/diff/1/src/core/SkRegion.cpp#newcode91 src/core/SkRegion.cpp:91: void SkRegion::freeRuns() { On ...

13 years, 2 months ago (2013-01-24 16:08:25 UTC) #4

Message was sent while issue was closed.

Committed revision 7366.

Expand All Messages | Collapse All Messages