Issue 7196054: environs/openstack: short timeouts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7196054: environs/openstack: short timeouts

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+144866

Visibility:
Public.

Description

environs/openstack: short timeouts There's no point waiting around the eventual consistency with the local server. Reduces the time to run environs/openstack tests from 42s to 9s. https://code.launchpad.net/~rogpeppe/juju-core/205-openstack-short-timeouts/+merge/144866 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/openstack: short timeouts #

Total comments: 3

Patch Set 3 : environs/openstack: short timeouts #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/openstack/local_test.go	View	1	4 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

LGTM. Drops the duration to 12 seconds for me, which is painful still but much ...

11 years, 3 months ago (2013-01-25 10:57:55 UTC) #2

wallyworld

LGTM. Thanks. https://codereview.appspot.com/7196054/diff/2001/environs/openstack/local_test.go File environs/openstack/local_test.go (right): https://codereview.appspot.com/7196054/diff/2001/environs/openstack/local_test.go#newcode8 environs/openstack/local_test.go:8: "net/http" On 2013/01/25 10:57:56, gz wrote: > ...

11 years, 3 months ago (2013-01-25 11:15:24 UTC) #3

rog

11 years, 3 months ago (2013-01-25 11:53:57 UTC) #4

*** Submitted:

environs/openstack: short timeouts

There's no point waiting around the eventual
consistency with the local server.

Reduces the time to run environs/openstack
tests from 42s to 9s.

R=gz, wallyworld
CC=
https://codereview.appspot.com/7196054

https://codereview.appspot.com/7196054/diff/2001/environs/openstack/local_tes...
File environs/openstack/local_test.go (right):

https://codereview.appspot.com/7196054/diff/2001/environs/openstack/local_tes...
environs/openstack/local_test.go:8: "net/http"
On 2013/01/25 10:57:56, gz wrote:
> Well, having these two packages with the same, generic name sucks. This is a
> reasonable workaround.

that's why i called the ec2 test double "ec2test", not "ec2"...

Expand All Messages | Collapse All Messages