Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1575)

Issue 7195054: Added toString to SkDrawLooper-derived classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by robertphillips
Modified:
11 years, 3 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This gives a little more visibility into the blurred rect case in the debugger. Unfortunately the lack of an SkPaint::toString limits how much is shown. SkPaint::toString is blocked on the visibility of SkFontDescriptor (it is in ports).

Patch Set 1 #

Total comments: 3

Patch Set 2 : Moved add_flag_to_string to SkStringUtils.h/.cpp #

Patch Set 3 : Removed debugging file that had crept into CL #

Patch Set 4 : Removed yet more cruft that had crept in #

Patch Set 5 : fixed some code length issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -32 lines) Patch
M debugger/SkObjectParser.cpp View 1 4 chunks +21 lines, -29 lines 0 comments Download
M gyp/core.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
M include/core/SkDrawLooper.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
A include/core/SkStringUtils.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkLayerDrawLooper.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A src/core/SkStringUtils.cpp View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/effects/SkBlurDrawLooper.cpp View 1 2 3 4 2 chunks +36 lines, -2 lines 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 2 3 4 2 chunks +98 lines, -0 lines 0 comments Download
M tests/QuickRejectTest.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
robertphillips
11 years, 3 months ago (2013-01-24 15:35:47 UTC) #1
DerekS
https://codereview.appspot.com/7195054/diff/1/src/effects/SkBlurDrawLooper.cpp File src/effects/SkBlurDrawLooper.cpp (right): https://codereview.appspot.com/7195054/diff/1/src/effects/SkBlurDrawLooper.cpp#newcode134 src/effects/SkBlurDrawLooper.cpp:134: str->append("dx: "); why not use str->appendf(...) to reduce the ...
11 years, 3 months ago (2013-01-25 14:11:26 UTC) #2
robertphillips
PTAL https://codereview.appspot.com/7195054/diff/1/src/effects/SkBlurDrawLooper.cpp File src/effects/SkBlurDrawLooper.cpp (right): https://codereview.appspot.com/7195054/diff/1/src/effects/SkBlurDrawLooper.cpp#newcode134 src/effects/SkBlurDrawLooper.cpp:134: str->append("dx: "); I thought using appendScalar was preferred ...
11 years, 3 months ago (2013-01-28 20:14:40 UTC) #3
DerekS
lgtm
11 years, 3 months ago (2013-01-28 20:20:50 UTC) #4
robertphillips
11 years, 3 months ago (2013-01-28 20:22:22 UTC) #5
Message was sent while issue was closed.
committed as r7422
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b