Issue 7195051: all: connect to API live.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7195051: all: connect to API live.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+144694

Visibility:
Public.

Description

all: connect to API live. https://code.launchpad.net/~rogpeppe/juju-core/201-api-connect/+merge/144694 Requires: https://code.launchpad.net/~rogpeppe/juju-core/204-cloudinit-ports/+merge/144685 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: connect to API live. #

Total comments: 5

Patch Set 3 : all: connect to API live. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -10 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/bootstrap.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	environs/ec2/ec2.go	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	environs/ec2/live_test.go	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	environs/jujutest/livetests.go	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	environs/openstack/provider.go	View	1 2	4 chunks	+13 lines, -7 lines	0 comments	Download
A	juju/apiconn_test.go	View		1 chunk	+45 lines, -0 lines	0 comments	Download
M	state/api/client.go	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	state/api/server.go	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

https://codereview.appspot.com/7195051/diff/2001/environs/ec2/ec2.go File environs/ec2/ec2.go (right): https://codereview.appspot.com/7195051/diff/2001/environs/ec2/ec2.go#newcode812 environs/ec2/ec2.go:812: SourceIPs: []string{"0.0.0.0/0"}, Hmm.. that doesn't feel great. Authentication must ...

11 years, 3 months ago (2013-01-24 13:47:45 UTC) #2

rog

11 years, 3 months ago (2013-01-24 14:27:04 UTC) #3

*** Submitted:

all: connect to API live.

R=niemeyer
CC=
https://codereview.appspot.com/7195051

https://codereview.appspot.com/7195051/diff/2001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/7195051/diff/2001/environs/ec2/ec2.go#newcode812
environs/ec2/ec2.go:812: SourceIPs: []string{"0.0.0.0/0"},
On 2013/01/24 13:47:45, niemeyer wrote:
> Hmm.. that doesn't feel great. Authentication must be introduced before this
is
> opened, otherwise anyone using juju Go would have a totally open deployment.

As discussed online, the capabilities of the API are not currently sufficient to
worry about this (you can only request a machine's instance id).

Authentication is next on the agenda.

https://codereview.appspot.com/7195051/diff/2001/state/api/server.go
File state/api/server.go (right):

https://codereview.appspot.com/7195051/diff/2001/state/api/server.go#newcode32
state/api/server.go:32: log.Printf("state/api: listening on %q", addr)
On 2013/01/24 13:47:45, niemeyer wrote:
> Message seems misplaced. It's not yet listening.

Done.

Expand All Messages | Collapse All Messages