Issue 7195049: code review 7195049: cmd/api: normalize byte to uint8 and rune to int32

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7195049: code review 7195049: cmd/api: normalize byte to uint8 and rune to int32 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by bradfitz

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, adg, mikio

Visibility:
Public.

Description

cmd/api: normalize byte to uint8 and rune to int32

Patch Set 1 #

Patch Set 2 : diff -r 45a405b5c63a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 45a405b5c63a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6ea4af4a1d5e https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1247 lines, -1222 lines)			Patch
M	api/go1.txt	View		350 chunks	+1156 lines, -1156 lines	0 comments	Download
M	api/next.txt	View	1	21 chunks	+64 lines, -64 lines	0 comments	Download
M	src/cmd/api/goapi.go	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/cmd/api/testdata/src/pkg/p1/golden.txt	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/cmd/api/testdata/src/pkg/p1/p1.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/cmd/api/testdata/src/pkg/p3/golden.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2013-01-24 04:59:53 UTC) #1

mikio

LGTM Thanks. On Thu, Jan 24, 2013 at 2:13 PM, <adg@golang.org> wrote: > What prompted ...

12 years, 3 months ago (2013-01-24 06:23:25 UTC) #3

bradfitz

12 years, 3 months ago (2013-01-29 00:45:51 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=f744ca9bba43 ***

cmd/api: normalize byte to uint8 and rune to int32

R=golang-dev, adg, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/7195049

Expand All Messages | Collapse All Messages