Environment relation tests and refactor

Environment relation tests and refactor

This is a start to tests for the environment relation code plus a bunch of
refactorings and tests that proceeded from there.

https://code.launchpad.net/~benji/juju-gui/bug-1083924-environment-relation-tests/+merge/144546

(do not edit description out of merge proposal)

[benji, 2013-01-23 17:44:29]

Please take a look.

[matthew.scott, 2013-01-23 20:23:15]

Requesting re-review; I cannot create more than one relation for any given
subordinate service (i.e.: puppet to both mysql and mediawiki).

I think this looks fine overall other than that, and I appreciate the changes in
naming that more closely match a lot of what is going on, though it will take
some getting used to on my part, I'm sure.

[teknico, 2013-01-24 11:24:11]

Land as is.

Thank you so much, Benji! Pay no attention to the old-school whiners above, ;-)
and feel free to disregard the oohs, aahs and silly jokes below. :-)

https://codereview.appspot.com/7195047/diff/1/app/views/topology/relation.js
File app/views/topology/relation.js (right):

https://codereview.appspot.com/7195047/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:88: processRelation: function(relation) {
Thank you, really. :-)

https://codereview.appspot.com/7195047/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:94: Y.each(endpoints, function(endpoint) {
Ditto. :-)

https://codereview.appspot.com/7195047/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:106: decorateRelations: function(relations) {
And on and on the goodness goes. :-)

https://codereview.appspot.com/7195047/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:116: var bpair =
views.DecoratedRelation(relation, source, target);
Shouldn't "bpair" become "drel" or something?

https://codereview.appspot.com/7195047/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/7195047/diff/1/app/views/utils.js#newcode827
app/views/utils.js:827: * Decorate a relation with some related/derrived data.
Typo: "derrived".

https://codereview.appspot.com/7195047/diff/1/app/views/utils.js#newcode843
app/views/utils.js:843: };
Yes Virginia, there's such a thing as too much decomposition. :-) This is
beautiful, thank you.

https://codereview.appspot.com/7195047/diff/1/test/test_topology_relation.js
File test/test_topology_relation.js (right):

https://codereview.appspot.com/7195047/diff/1/test/test_topology_relation.js#...
test/test_topology_relation.js:42: var fauxTopo = {
"faux" is French, and "Topo" is Italian. In English it would be "fakeMouse". ;-)
(Not really, I know. :-) )

https://codereview.appspot.com/7195047/diff/1/undocumented
File undocumented (left):

https://codereview.appspot.com/7195047/diff/1/undocumented#oldcode153
undocumented:153: app/views/topology/relation.js:101 "processRelations"
Progress! :-)

[benji, 2013-01-24 16:55:09]

Please take a look.

https://codereview.appspot.com/7195047/diff/1/app/views/topology/relation.js
File app/views/topology/relation.js (right):

https://codereview.appspot.com/7195047/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:116: var bpair =
views.DecoratedRelation(relation, source, target);
On 2013/01/24 11:24:11, teknico wrote:
> Shouldn't "bpair" become "drel" or something?

Yep.  The best I could come up with was "decoratedRelation" (since the result
list is already "decorated") so I went with that.

https://codereview.appspot.com/7195047/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/7195047/diff/1/app/views/utils.js#newcode827
app/views/utils.js:827: * Decorate a relation with some related/derrived data.
On 2013/01/24 11:24:11, teknico wrote:
> Typo: "derrived".

Done.

https://codereview.appspot.com/7195047/diff/1/test/test_topology_relation.js
File test/test_topology_relation.js (right):

https://codereview.appspot.com/7195047/diff/1/test/test_topology_relation.js#...
test/test_topology_relation.js:42: var fauxTopo = {
On 2013/01/24 11:24:11, teknico wrote:
> "faux" is French, and "Topo" is Italian. In English it would be "fakeMouse".
;-)
> (Not really, I know. :-) )

heh

[matthew.scott, 2013-01-24 17:16:23]

Looks good, thanks for the fix!  Land as is.

[benji, 2013-01-24 19:05:23]

*** Submitted:

Environment relation tests and refactor

This is a start to tests for the environment relation code plus a bunch of
refactorings and tests that proceeded from there.

R=matthew.scott, teknico
CC=
https://codereview.appspot.com/7195047