Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 7191045: code review 7191045: text/template/parse: move itemType.String from test cod... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by dsymonds
Modified:
13 years, 4 months ago
Reviewers:
rsc, golang-dev
Visibility:
Public.

Description

text/template/parse: move itemType.String from test code into real code. itemType is used in a few places to report errors to users of text/template. Without String you get errors such as template: :96: expected %!s(parse.itemType=14) in else; got "/" With String you get template: :96: expected right delim in else; got "/"

Patch Set 1 #

Patch Set 2 : diff -r 4dca3cb86ca7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4dca3cb86ca7 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -43 lines) Patch
M src/pkg/text/template/parse/lex.go View 1 1 chunk +42 lines, -0 lines 0 comments Download
M src/pkg/text/template/parse/lex_test.go View 1 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 5
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2013-01-23 00:53:32 UTC) #1
dsymonds
This is purely a copy-and-paste, plus the adjustment of the imports.
13 years, 4 months ago (2013-01-23 00:55:22 UTC) #2
rsc
I believe CL 7128054 already fixed the problem.
13 years, 4 months ago (2013-01-23 02:49:48 UTC) #3
dsymonds
Nuts. You're right. My client was stale.
13 years, 4 months ago (2013-01-23 02:55:22 UTC) #4
dsymonds
13 years, 4 months ago (2013-01-23 02:55:41 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b