Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(198)

Issue 7189043: Allow creating non-FINAL release tarballs.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by frankban
Modified:
8 years, 3 months ago
Reviewers:
mp+144245
Visibility:
Public.

Description

Allow creating non-FINAL release tarballs. In the charm, when juju-gui-source is a branch, a release tarball is created from the checkout running "NO_BZR=1 make distfile". The "distfile" target was included in the released/unreleased check by our Makefile. This means that trying to deploy the charm from a branch whose CHANGES.yaml does not include "unreleased:" always fails with the error reported by therve: "non-FINAL releases must have a most-recent version number of unreleased in CHANGES.yaml". This branch removes that check from the distfile target: I think we should protect "dist", but I don't see, given the problems described above, a valid reason to continue preventing users to create non-FINAL tarballs, even if the branch is a final release. https://code.launchpad.net/~frankban/juju-gui/bug-1102633-make-distfile/+merge/144245 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Allow creating non-FINAL release tarballs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
8 years, 3 months ago (2013-01-22 09:08:56 UTC) #1
teknico
Land as is. This looks like a reasonable fix to the mismatch.
8 years, 3 months ago (2013-01-22 11:23:53 UTC) #2
bac
Thank you. Land as is.
8 years, 3 months ago (2013-01-22 11:51:09 UTC) #3
frankban
8 years, 3 months ago (2013-01-22 11:55:20 UTC) #4
*** Submitted:

Allow creating non-FINAL release tarballs.

In the charm, when juju-gui-source is a branch,
a release tarball is created from the checkout
running "NO_BZR=1 make distfile".
The "distfile" target was included in the 
released/unreleased check by our Makefile.
This means that trying to deploy the charm
from a branch whose CHANGES.yaml does not
include "unreleased:" always fails with 
the error reported by therve: 
"non-FINAL releases must have a most-recent 
version number of unreleased in CHANGES.yaml".
This branch removes that check from the distfile
target: I think we should protect "dist", but
I don't see, given the problems described above,
a valid reason to continue preventing users
to create non-FINAL tarballs, even if the 
branch is a final release.

R=teknico, bac
CC=
https://codereview.appspot.com/7189043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b