Issue 7185043: code review 7185043: crypto/x509: skip SystemRootsError test on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7185043: code review 7185043: crypto/x509: skip SystemRootsError test on Windows

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by mkrautz

Modified:
11 years, 12 months ago

Reviewers:
agl1

CC:
golang-dev, agl1, snaury, minux1

Visibility:
Public.

Description

crypto/x509: skip SystemRootsError test on Windows On Windows, crypto/x509 passes through to Windows's CryptoAPI to verify certificate chains. This method can't produce a SystemRootsError, so make sure we always skip the test on Windows. This is needed because testVerify is called in both TestGoVerify and TestSystemVerify on Windows - one is for testing the Go verifier, the other one is for testing the CryptoAPI verifier. The orignal CL tried to sidestep this issue by setting systemSkip to true, but that only affected TestSystemVerify.

Patch Set 1 #

Patch Set 2 : diff -r d499282de902 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d499282de902 https://code.google.com/p/go/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/pkg/crypto/x509/verify_test.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

mkrautz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 5 months ago (2013-01-21 20:08:29 UTC) #1

mkrautz

On 2013/01/21 20:41:06, agl1 wrote: > LGTM, sorry about that. I am to blame. I ...

12 years, 5 months ago (2013-01-21 20:48:17 UTC) #3

snaury

On 2013/01/21 20:41:06, agl1 wrote: > LGTM, sorry about that. It's been broken for 3 ...

12 years, 5 months ago (2013-01-23 05:59:33 UTC) #4

minux1

*** Submitted as https://code.google.com/p/go/source/detail?r=d8bddc63dacc *** crypto/x509: skip SystemRootsError test on Windows On Windows, crypto/x509 passes ...

12 years, 5 months ago (2013-01-23 17:20:30 UTC) #6

R=close

Expand All Messages | Collapse All Messages