Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(603)

Issue 7181052: code review 7181052: time: make TestReset more reliable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by bradfitz
Modified:
7 years, 12 months ago
Reviewers:
CC:
golang-dev, brainman, mikio
Visibility:
Public.

Description

time: make TestReset more reliable Fixes issue 4690

Patch Set 1 #

Patch Set 2 : diff -r 0aa3f72c1c8b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0aa3f72c1c8b https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r c3f6b7dd0104 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M src/pkg/time/sleep_test.go View 1 2 3 1 chunk +33 lines, -10 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 12 months ago (2013-01-23 00:30:49 UTC) #1
brainman
LGTM
7 years, 12 months ago (2013-01-23 01:14:34 UTC) #2
mikio
LGTM https://codereview.appspot.com/7181052/diff/4002/src/pkg/time/sleep_test.go File src/pkg/time/sleep_test.go (right): https://codereview.appspot.com/7181052/diff/4002/src/pkg/time/sleep_test.go#newcode283 src/pkg/time/sleep_test.go:283: 500 * Millisecond, or maybe bin exp. backoff ...
7 years, 12 months ago (2013-01-23 01:16:11 UTC) #3
bradfitz
7 years, 12 months ago (2013-01-23 01:26:01 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=a50963036915 ***

time: make TestReset more reliable

Fixes issue 4690

R=golang-dev, alex.brainman, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/7181052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b