openstack: bootstrap + tests

openstack: bootstrap + tests

Implemented environment bootstrap for the openstack provider + tests
using goose test doubles.

https://code.launchpad.net/~dimitern/juju-core/openstack-bootstrap/+merge/144292

(do not edit description out of merge proposal)

[dimitern, 2013-01-22 11:57:03]

Please take a look.

[rog, 2013-01-23 11:12:07]

looks good, with a few remarks below.

https://codereview.appspot.com/7181046/diff/1/environs/openstack/live_test.go
File environs/openstack/live_test.go (right):

https://codereview.appspot.com/7181046/diff/1/environs/openstack/live_test.go...
environs/openstack/live_test.go:45: "authorized-keys": "foo",
i'm not sure you want authorized-keys here. that means that you won't be able to
ssh to any instances that have been started (which is crucial for debugging
cloudinit failures).

https://codereview.appspot.com/7181046/diff/1/environs/openstack/live_test.go...
environs/openstack/live_test.go:88: CanOpenState:   false, // no state, just
local tests
"just local tests" is not quite right - it's still starting genuine live
instances, no?

https://codereview.appspot.com/7181046/diff/1/environs/openstack/provider.go
File environs/openstack/provider.go (right):

https://codereview.appspot.com/7181046/diff/1/environs/openstack/provider.go#...
environs/openstack/provider.go:173: // up yet, so we retry to verify if that is
happening.
do we have the same eventual consistency issues with openstack as we do in ec2?
if we don't, it would be very nice to keep the code cleaner.

[niemeyer, 2013-01-23 13:06:56]

LGTM

https://codereview.appspot.com/7181046/diff/1/environs/openstack/provider.go
File environs/openstack/provider.go (right):

https://codereview.appspot.com/7181046/diff/1/environs/openstack/provider.go#...
environs/openstack/provider.go:173: // up yet, so we retry to verify if that is
happening.
As we covered online, looks like the problem is the same.

[dimitern, 2013-01-23 13:19:55]

Please take a look.

https://codereview.appspot.com/7181046/diff/1/environs/openstack/live_test.go
File environs/openstack/live_test.go (right):

https://codereview.appspot.com/7181046/diff/1/environs/openstack/live_test.go...
environs/openstack/live_test.go:45: "authorized-keys": "foo",
On 2013/01/23 11:12:08, rog wrote:
> i'm not sure you want authorized-keys here. that means that you won't be able
to
> ssh to any instances that have been started (which is crucial for debugging
> cloudinit failures).
Ok, removed. Wasn't sure if I need it anyway.

https://codereview.appspot.com/7181046/diff/1/environs/openstack/live_test.go...
environs/openstack/live_test.go:88: CanOpenState:   false, // no state, just
local tests
On 2013/01/23 11:12:08, rog wrote:
> "just local tests" is not quite right - it's still starting genuine live
> instances, no?
Well, it does but if -live is passed only. Otherwise it uses the test doubles
locally. I'm update the comment to clarify.

https://codereview.appspot.com/7181046/diff/1/environs/openstack/provider.go
File environs/openstack/provider.go (right):

https://codereview.appspot.com/7181046/diff/1/environs/openstack/provider.go#...
environs/openstack/provider.go:173: // up yet, so we retry to verify if that is
happening.
On 2013/01/23 11:12:08, rog wrote:
> do we have the same eventual consistency issues with openstack as we do in
ec2?
> if we don't, it would be very nice to keep the code cleaner.
AFAIK we do have the same issues, so I thought it's best to keep the code as is.

[rog, 2013-01-23 13:22:47]

LGTM

[dimitern, 2013-01-23 13:23:42]

*** Submitted:

openstack: bootstrap + tests

Implemented environment bootstrap for the openstack provider + tests
using goose test doubles.

R=rog, niemeyer
CC=
https://codereview.appspot.com/7181046