Issue 7181045: code review 7181045: syscall: fix arithmetic errors in assembly for seek fun...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7181045: code review 7181045: syscall: fix arithmetic errors in assembly for seek fun... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by akumar

Modified:
12 years, 5 months ago

Reviewers:

CC:
rsc, rminnich, npe1, golang-dev

Visibility:
Public.

Description

syscall: fix arithmetic errors in assembly for seek function for 64-bit Plan 9 Offsets for return values from seek were miscalculated and a translation from 32-bit code for error handling was incorrect.

Patch Set 1 #

Patch Set 2 : diff -r 6287072632c4 https://code.google.com/p/go #

Patch Set 3 : diff -r 6287072632c4 https://code.google.com/p/go #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	src/pkg/syscall/asm_plan9_amd64.s	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

akumar

Hello rsc@golang.org, rminnich@gmail.com, npe@plan9.bell-labs.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 5 months ago (2013-01-22 04:01:31 UTC) #1

rsc

12 years, 5 months ago (2013-01-22 19:03:34 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=df35e1b42c5b ***

syscall: fix arithmetic errors in assembly for seek function for 64-bit Plan 9

Offsets for return values from seek were miscalculated
and a translation from 32-bit code for error handling
was incorrect.

R=rsc, rminnich, npe
CC=golang-dev
https://codereview.appspot.com/7181045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages