Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(576)

Issue 7179043: environs/jujutest: fix test

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rog
Modified:
11 years, 3 months ago
Reviewers:
mp+144124
Visibility:
Public.

Description

environs/jujutest: fix test Fix TestBootstrapWithDefaultSeries. It relied on the environment being unbootstrapped. Gustavo thinks this test should really be deleted, and replaced by a functional test elsewhere, but I'd like to do both at the same time when we do that. https://code.launchpad.net/~rogpeppe/juju-core/199-fix-TestBootstrapWithDefaultSeries/+merge/144124 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/jujutest: fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M environs/jujutest/livetests.go View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
11 years, 4 months ago (2013-01-21 14:35:55 UTC) #1
jameinel
thanks for the comment. So if we start failing because destroyed environs can't connect to ...
11 years, 4 months ago (2013-01-22 08:13:37 UTC) #2
dimitern
LGTM, nice to know.
11 years, 4 months ago (2013-01-22 13:40:22 UTC) #3
rog
11 years, 3 months ago (2013-01-23 16:45:10 UTC) #4
*** Submitted:

environs/jujutest: fix test

Fix TestBootstrapWithDefaultSeries.
It relied on the environment being unbootstrapped.

Gustavo thinks this test should really
be deleted, and replaced by a functional
test elsewhere, but I'd like to do both
at the same time when we do that.

R=jameinel, dimitern
CC=
https://codereview.appspot.com/7179043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b