Issue 71790044: code review 71790044: spec: be more precise about underlying types of predecl...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 71790044: code review 71790044: spec: be more precise about underlying types of predecl... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by gri

Modified:
11 years ago

Reviewers:
r, rsc

CC:
r, rsc, iant, ken2, golang-codereviews

Visibility:
Public.

Description

spec: be more precise about underlying types of predeclared types The underlying type of the predeclared type error is not itself, but the interface it is defined as. Fixes issue 7444.

Patch Set 1 #

Patch Set 2 : diff -r 3384febe93d5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3384febe93d5 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3384febe93d5 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 82edfcdee1bc https://code.google.com/p/go #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	doc/go_spec.html	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org, rsc@golang.org, iant@golang.org, ken@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...

11 years ago (2014-03-06 00:29:01 UTC) #1

gri

11 years ago (2014-03-06 03:37:40 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=877a41585fc7 ***

spec: be more precise about underlying types of predeclared types

The underlying type of the predeclared type error is not itself,
but the interface it is defined as.

Fixes issue 7444.

LGTM=r, rsc
R=r, rsc, iant, ken
CC=golang-codereviews
https://codereview.appspot.com/71790044

Expand All Messages | Collapse All Messages