Issue 71750048: code review 71750048: runtime: fix malloc page alignment + efence

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 71750048: code review 71750048: runtime: fix malloc page alignment + efence (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
iant

CC:
golang-codereviews, josharian, iant, dvyukov

Visibility:
Public.

Description

runtime: fix malloc page alignment + efence Two memory allocator bug fixes. - efence is not maintaining the proper heap metadata to make eventual memory reuse safe, so use SysFault. - now that our heap PageSize is 8k but most hardware uses 4k pages, SysAlloc and SysReserve results must be explicitly aligned. Do that in a few more call sites and document this fact in malloc.h. Fixes issue 7448.

Patch Set 1 #

Patch Set 2 : diff -r 6d3659ee6de3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6d3659ee6de3 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 7cb38c8ff249 https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -23 lines)			Patch
M	src/pkg/runtime/malloc.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/malloc.goc	View	1 2 3	8 chunks	+60 lines, -22 lines	0 comments	Download
M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2014-03-06 21:02:42 UTC) #1

rsc

11 years, 3 months ago (2014-03-06 23:34:32 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=554ebde9399a ***

runtime: fix malloc page alignment + efence

Two memory allocator bug fixes.

- efence is not maintaining the proper heap metadata
  to make eventual memory reuse safe, so use SysFault.

- now that our heap PageSize is 8k but most hardware
  uses 4k pages, SysAlloc and SysReserve results must be
  explicitly aligned. Do that in a few more call sites and
  document this fact in malloc.h.

Fixes issue 7448.

LGTM=iant
R=golang-codereviews, josharian, iant
CC=dvyukov, golang-codereviews
https://codereview.appspot.com/71750048

Expand All Messages | Collapse All Messages