Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(381)

Issue 7174045: Fix various breakage around menu handling

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by bcsaller
Modified:
8 years, 3 months ago
Reviewers:
mp+144202
Visibility:
Public.

Description

Fix various breakage around menu handling Fixed issues from merge around method name change and fixed strange interaction issues with click and dragstart both interacting with the menu on non-drag events (dragstart it seems is called on any bound targets click). https://code.launchpad.net/~bcsaller/juju-gui/menu-click-fix/+merge/144202 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix various breakage around menu handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/service.js View 1 9 chunks +20 lines, -13 lines 0 comments Download
M app/views/topology/topology.js View 2 chunks +1 line, -1 line 0 comments Download
M test/test_service_module.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_topology.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
bcsaller
Please take a look.
8 years, 3 months ago (2013-01-22 01:51:34 UTC) #1
frankban
Land as is. Hi Ben, this branch looks good and fixes two bugs (menu-view and ...
8 years, 3 months ago (2013-01-22 09:49:19 UTC) #2
teknico
Land with changes. Thanks for fixing this. The proposed changes below are not mandatory, just ...
8 years, 3 months ago (2013-01-22 11:20:08 UTC) #3
bcsaller
8 years, 3 months ago (2013-01-22 13:43:54 UTC) #4
*** Submitted:

Fix various breakage around menu handling

Fixed issues from merge around method name change and fixed strange
interaction issues with click and dragstart both interacting with the menu on
non-drag events (dragstart it seems is called on any bound targets click).

R=frankban, teknico
CC=
https://codereview.appspot.com/7174045

https://codereview.appspot.com/7174045/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/7174045/diff/1/app/views/topology/service.js#n...
app/views/topology/service.js:203: .toggleServiceMenu(box, context);
On 2013/01/22 11:20:08, teknico wrote:
> That's a hideServiceMenu too.
Thanks, well spotted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b