code review 71550044: cmd/dist: use vfprintf on Windows, same as on Unix

cmd/dist: use vfprintf on Windows, same as on Unix

Apparently, the Windows routines sometimes fail to generate output.
Copy the Unix stdio-based implementations instead.

Suggested by Pietro Gagliardi in CL 65280043 but that CL
seems to have been abandoned.

Fixes issue 7242.

[rsc, 2014-03-05 19:06:58]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-03-05 19:08:21]

LGTM



On Wed, Mar 5, 2014 at 11:06 AM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/dist: use vfprintf on Windows, same as on Unix
>
> Apparently, the Windows routines sometimes fail to generate output.
> Copy the Unix stdio-based implementations instead.
>
> Suggested by Pietro Gagliardi in CL 65280043 but that CL
> seems to have been abandoned.
>
> Fixes issue 7242.
>
> Please review this at https://codereview.appspot.com/71550044/
>
> Affected files (+4, -18 lines):
>   M src/cmd/dist/windows.c
>
>
> Index: src/cmd/dist/windows.c
> ===================================================================
> --- a/src/cmd/dist/windows.c
> +++ b/src/cmd/dist/windows.c
> @@ -840,34 +840,20 @@
>  xprintf(char *fmt, ...)
>  {
>         va_list arg;
> -       char *p;
> -       DWORD n, w;
> -
> +
>         va_start(arg, fmt);
> -       n = vsnprintf(NULL, 0, fmt, arg);
> -       p = xmalloc(n+1);
> -       vsnprintf(p, n+1, fmt, arg);
> +       vprintf(fmt, arg);
>         va_end(arg);
> -       w = 0;
> -       WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), p, n, &w, 0);
> -       xfree(p);
>  }
>
>  void
>  errprintf(char *fmt, ...)
>  {
>         va_list arg;
> -       char *p;
> -       DWORD n, w;
> -
> +
>         va_start(arg, fmt);
> -       n = vsnprintf(NULL, 0, fmt, arg);
> -       p = xmalloc(n+1);
> -       vsnprintf(p, n+1, fmt, arg);
> +       vfprintf(stderr, fmt, arg);
>         va_end(arg);
> -       w = 0;
> -       WriteFile(GetStdHandle(STD_ERROR_HANDLE), p, n, &w, 0);
> -       xfree(p);
>  }
>
>  int
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[rsc, 2014-03-05 19:16:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=cbf5f409e6e5 ***

cmd/dist: use vfprintf on Windows, same as on Unix

Apparently, the Windows routines sometimes fail to generate output.
Copy the Unix stdio-based implementations instead.

Suggested by Pietro Gagliardi in CL 65280043 but that CL
seems to have been abandoned.

Fixes issue 7242.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/71550044

[gobot, 2014-03-06 05:55:04]

This CL appears to have broken the windows-amd64-race builder.