code review 7148043: testing: catch panicking example and report, just like tests

testing: catch panicking example and report, just like tests

Fixes issue 4670.

[adg, 2013-01-17 06:29:24]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-01-17 14:17:14]

https://codereview.appspot.com/7148043/diff/1/src/pkg/testing/example.go
File src/pkg/testing/example.go (right):

https://codereview.appspot.com/7148043/diff/1/src/pkg/testing/example.go#newc...
src/pkg/testing/example.go:91: panic(err)
Really?  What catches this one?

[rsc, 2013-01-17 14:18:04]

LGTM

Just saw your comment on the issue.
Having the FAIL line is useful: at least it tells you what failed.

[adg, 2013-01-17 23:26:15]

https://codereview.appspot.com/7148043/diff/1/src/pkg/testing/example.go
File src/pkg/testing/example.go (right):

https://codereview.appspot.com/7148043/diff/1/src/pkg/testing/example.go#newc...
src/pkg/testing/example.go:91: panic(err)
On 2013/01/17 14:17:14, rsc wrote:
> Really?  What catches this one?

I was surprised, too, but that's what happens for tests, too.

I think it's probably a good idea not to run further tests if one test fails. If
tests share state (initialized with sync.Once or something), then it can't be
assumed that the environment is sane after one test panics.

[adg, 2013-01-17 23:28:28]

*** Submitted as https://code.google.com/p/go/source/detail?r=4a17cdd58cb1 ***

testing: catch panicking example and report, just like tests

Fixes issue 4670.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7148043

[dave_cheney.net, 2013-01-18 01:13:02]

Umm, this change may have had the opposite effect, all the builders
are now broken.

On Fri, Jan 18, 2013 at 10:28 AM,  <adg@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=4a17cdd58cb1 ***
>
>
> testing: catch panicking example and report, just like tests
>
> Fixes issue 4670.
>
> R=rsc
> CC=golang-dev
> https://codereview.appspot.com/7148043
>
>
> https://codereview.appspot.com/7148043/

[adg, 2013-01-18 01:24:32]

On 18 January 2013 12:13, Dave Cheney <dave@cheney.net> wrote:

> Umm, this change may have had the opposite effect, all the builders
> are now broken.
>


Oops. Fix incoming.