Disable charm store stats when testing.

Disable charm store stats when testing.

When JUJU_TESTING is set to a non empty string value.

- Disable charm stats when getting charm-info or downloading charms.

When JUJU_TESTING is set to 'fast'

- For test instance startup speed, diable apt update/upgrade, also
  propogates to provisioning agent.

https://code.launchpad.net/~hazmat/juju/test-sans-stat/+merge/143598

(do not edit description out of merge proposal)

[hazmat, 2013-01-16 21:45:28]

Please take a look.

[hazmat, 2013-01-16 21:47:30]

On 2013/01/16 21:45:28, hazmat wrote:
> Please take a look.

this also enables daily releases on ec2 in testing mode to make up for the
update/upgrade omission.

[gary.poster, 2013-01-21 22:08:53]

Hi Kapil.  I have zero valuable specific code comments: it looks good, thank
you.

In the bigger picture of Clint's comments, in discussion we both seemed to think
his concerns had merit.  However, your concern was that AWS adds about three
minutes per test setup for the update, and HP as much as 10.  This can kill a
desire to run tests.

We discussed the possibility of making the apt-get update opt-in or explicitly
opt-out, separate from disabling the statistics.  In my comment below, I lean
towards opt-out.  It seems to me that would let us address Clint's concerns most
completely.  Do what you think, as far as I'm concerned.  The important part to
me is that CI tests, once we have them, will be full tests, including apt-get
update etc.; and that devs can run fast tests if they want.

Gary

https://codereview.appspot.com/7143043/diff/1/juju/charm/repository.py
File juju/charm/repository.py (right):

https://codereview.appspot.com/7143043/diff/1/juju/charm/repository.py#newcod...
juju/charm/repository.py:121: self.no_stats =
bool(os.environ.get("JUJU_TESTING"))
Per our brief discussion about Clint's comment, I think it would be good to have
two separate flags--JUJU_TESTING and JUJU_FAST_TESTING, perhaps?  Those semantic
ideas, anyway?  no_stats would be True for both flags, IIUC.

https://codereview.appspot.com/7143043/diff/1/juju/charm/repository.py#newcod...
juju/charm/repository.py:135: all_info = json.loads(
thank you.  nice whitespace :-)

https://codereview.appspot.com/7143043/diff/1/juju/providers/common/utils.py
File juju/providers/common/utils.py (right):

https://codereview.appspot.com/7143043/diff/1/juju/providers/common/utils.py#...
juju/providers/common/utils.py:130: if bool(os.environ.get("JUJU_TESTING")):
This would be JUJU_FAST_TESTING or similar

[teknico, 2013-01-22 12:02:18]

Land with changes.

The comments below are not very important (definitely less than Gary's ones),
but may be of interest.

https://codereview.appspot.com/7143043/diff/1/juju/charm/tests/test_repositor...
File juju/charm/tests/test_repository.py (right):

https://codereview.appspot.com/7143043/diff/1/juju/charm/tests/test_repositor...
juju/charm/tests/test_repository.py:362:
"https://somewhe.re/charm/series/name-1?stats=0")
This domain name is actually registered in Réunion. :-) You may want to use
"example.com", which is intended for these kind of things. Just in case. :-)

https://codereview.appspot.com/7143043/diff/1/juju/providers/common/tests/tes...
File juju/providers/common/tests/test_utils.py (right):

https://codereview.appspot.com/7143043/diff/1/juju/providers/common/tests/tes...
juju/providers/common/tests/test_utils.py:124: scripts = ["wget http://lwn.net >
/tmp/out"]
Not sure how this works, are we really hitting the Linux Weekly News servers
each time we run tests? If so, we may want to use one of our own servers.

https://codereview.appspot.com/7143043/diff/1/juju/providers/ec2/tests/test_u...
File juju/providers/ec2/tests/test_utils.py (right):

https://codereview.appspot.com/7143043/diff/1/juju/providers/ec2/tests/test_u...
juju/providers/ec2/tests/test_utils.py:24:
https://%s/query/%%s/server/daily.current.txt" % (IMAGE_HOST)
The following wrapping would avoid the ugly continuation backslash:
STREAM_URI_TEMPLATE = "24 https://%s/query/%%s/server/daily.current.txt" % (
    IMAGE_HOST)

https://codereview.appspot.com/7143043/diff/1/juju/providers/ec2/tests/test_u...
juju/providers/ec2/tests/test_utils.py:71:
self.change_environment(JUJU_TESTING="YES")
You used JUJU_TESTING="1" elsewhere. Yes, anything non-false would work, but is
using a different value intentional?

https://codereview.appspot.com/7143043/diff/1/juju/providers/ec2/utils.py
File juju/providers/ec2/utils.py (right):

https://codereview.appspot.com/7143043/diff/1/juju/providers/ec2/utils.py#new...
juju/providers/ec2/utils.py:63: "https://%s/query/%s/server/daily.current.txt")
Thanks for not using an ugly continuation backslash here. :-)

https://codereview.appspot.com/7143043/diff/1/juju/providers/ec2/utils.py#new...
juju/providers/ec2/utils.py:107: uri = _CURRENT_IMAGE_URI_TEMPLATE %
(_CURRENT_IMAGE_HOST, series)
Is this two-liner an improvement?

    uri = (_STREAM_IMAGE_URI_TEMPLATE if bool(os.environ.get("JUJU_TESTING")
        ) else _CURRENT_IMAGE_URI_TEMPLATE) % (_CURRENT_IMAGE_HOST, series)

https://codereview.appspot.com/7143043/diff/1/juju/providers/ec2/utils.py#new...
juju/providers/ec2/utils.py:112: contextFactory = None
Similarly:

    contextFactory = VerifyingContextFactory(_CURRENT_IMAGE_HOST) if (
        ssl and ssl_verify) else None

[hazmat, 2013-01-29 16:56:21]

*** Submitted:

Disable charm store stats when testing.

When JUJU_TESTING is set to a non empty string value.

- Disable charm stats when getting charm-info or downloading charms.

When JUJU_TESTING is set to 'fast'

- For test instance startup speed, diable apt update/upgrade, also
  propogates to provisioning agent.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7143043