Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 7143043: Disable charm store stats when testing.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by hazmat
Modified:
9 years, 6 months ago
Reviewers:
mp+143598
Visibility:
Public.

Description

Disable charm store stats when testing. When JUJU_TESTING is set to a non empty string value. - Disable charm stats when getting charm-info or downloading charms. When JUJU_TESTING is set to 'fast' - For test instance startup speed, diable apt update/upgrade, also propogates to provisioning agent. https://code.launchpad.net/~hazmat/juju/test-sans-stat/+merge/143598 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 10

Patch Set 2 : Disable charm store stats when testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -8 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/charm/repository.py View 3 chunks +12 lines, -2 lines 0 comments Download
M juju/charm/tests/test_repository.py View 1 chunk +7 lines, -0 lines 0 comments Download
M juju/providers/common/cloudinit.py View 1 2 chunks +6 lines, -1 line 0 comments Download
A juju/providers/common/tests/data/cloud_init_bootstrap_testing View 1 1 chunk +62 lines, -0 lines 0 comments Download
M juju/providers/common/tests/test_cloudinit.py View 1 2 chunks +9 lines, -1 line 0 comments Download
M juju/providers/common/tests/test_utils.py View 1 2 chunks +34 lines, -1 line 0 comments Download
M juju/providers/common/utils.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M juju/providers/ec2/tests/test_utils.py View 1 2 chunks +18 lines, -2 lines 0 comments Download
M juju/providers/ec2/utils.py View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5
hazmat
Please take a look.
9 years, 6 months ago (2013-01-16 21:45:28 UTC) #1
hazmat
On 2013/01/16 21:45:28, hazmat wrote: > Please take a look. this also enables daily releases ...
9 years, 6 months ago (2013-01-16 21:47:30 UTC) #2
gary.poster
Hi Kapil. I have zero valuable specific code comments: it looks good, thank you. In ...
9 years, 6 months ago (2013-01-21 22:08:53 UTC) #3
teknico
Land with changes. The comments below are not very important (definitely less than Gary's ones), ...
9 years, 6 months ago (2013-01-22 12:02:18 UTC) #4
hazmat
9 years, 6 months ago (2013-01-29 16:56:21 UTC) #5
*** Submitted:

Disable charm store stats when testing.

When JUJU_TESTING is set to a non empty string value.

- Disable charm stats when getting charm-info or downloading charms.

When JUJU_TESTING is set to 'fast'

- For test instance startup speed, diable apt update/upgrade, also
  propogates to provisioning agent.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7143043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b