Issue 7142048: code review 7142048: html/template: remove noescape support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7142048: code review 7142048: html/template: remove noescape support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by adg

Modified:
12 years, 9 months ago

Reviewers:

CC:
MikeSamuel, rsc, golang-dev

Visibility:
Public.

Description

html/template: remove noescape support This was never documented or properly implemented. Fixes issue 3528.

Patch Set 1 #

Patch Set 2 : diff -r a55bd9f21507 https://code.google.com/p/go #

Patch Set 3 : diff -r 4a17cdd58cb1 https://code.google.com/p/go #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -15 lines)			Patch
M	doc/go1.1.html	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/html/template/escape.go	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	src/pkg/html/template/escape_test.go	View		2 chunks	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello mikesamuel (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 9 months ago (2013-01-17 07:07:24 UTC) #1

rsc

LGTM Please add to go1.1.html: html/template Templates using the undocumented and only partially implemented "noescape" ...

12 years, 9 months ago (2013-01-17 14:19:57 UTC) #2

MikeSamuel

On 2013/01/17 07:07:24, adg wrote: > Hello mikesamuel (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

12 years, 9 months ago (2013-01-17 15:08:15 UTC) #3

adg

12 years, 9 months ago (2013-01-17 23:30:22 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=938597eab997 ***

html/template: remove noescape support

This was never documented or properly implemented.

Fixes issue 3528.

R=mikesamuel, rsc
CC=golang-dev
https://codereview.appspot.com/7142048

Expand All Messages | Collapse All Messages