Issue 7141059: Fix login for Kapil's upcoming rapi branch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7141059: Fix login for Kapil's upcoming rapi branch

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by gary.poster

Modified:
11 years, 4 months ago

Reviewers:
mp+143948

Visibility:
Public.

Description

Fix login for Kapil's upcoming rapi branch The login needed to trigger the dispatch after the "connected" property change, not while it was changing. https://code.launchpad.net/~gary/juju-gui/fixlogin/+merge/143948 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix login for Kapil's upcoming rapi branch #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_app.js	View	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bac

Looks good, thanks. https://codereview.appspot.com/7141059/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7141059/diff/1/app/app.js#newcode263 app/app.js:263: this.env.after('connectedChange', function(ev) { nice change

11 years, 4 months ago (2013-01-18 21:57:25 UTC) #2

gary.poster

11 years, 4 months ago (2013-01-18 22:00:06 UTC) #3

*** Submitted:

Fix login for Kapil's upcoming rapi branch

The login needed to trigger the dispatch after the "connected" property change,
not while it was changing.

R=bac
CC=
https://codereview.appspot.com/7141059

Expand All Messages | Collapse All Messages