Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(540)

Issue 7141043: Rerender relation when unit count changes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by matthew.scott
Modified:
8 years, 2 months ago
Reviewers:
bac, mp+143552
Visibility:
Public.

Description

Rerender relation when unit count changes. If a service was rescaled due to unit count changing, relation endpoints were still pointing to the edge of the service block as it was scaled before. Now, relation endpoints are updated as well. Includes a test of this functionality. https://code.launchpad.net/~makyo/juju-gui/relation-rerender-1098715/+merge/143552 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rerender relation when unit count changes. #

Patch Set 3 : Rerender relation when unit count changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/relation.js View 2 chunks +8 lines, -2 lines 0 comments Download
M test/test_environment_view.js View 1 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
8 years, 2 months ago (2013-01-16 16:51:22 UTC) #1
gary.poster
Land with changes. Looks great Matt, thank you. Trivial comments/requests. Gary https://codereview.appspot.com/7141043/diff/1/test/test_environment_view.js File test/test_environment_view.js (right): ...
8 years, 2 months ago (2013-01-16 19:09:08 UTC) #2
bac
LGTMT. https://codereview.appspot.com/7141043/diff/1/test/test_environment_view.js File test/test_environment_view.js (right): https://codereview.appspot.com/7141043/diff/1/test/test_environment_view.js#newcode280 test/test_environment_view.js:280: }).render(), On 2013/01/16 19:09:08, gary.poster wrote: > Alternatively, ...
8 years, 2 months ago (2013-01-16 19:15:47 UTC) #3
matthew.scott
8 years, 2 months ago (2013-01-16 19:50:46 UTC) #4
*** Submitted:

Rerender relation when unit count changes.

If a service was rescaled due to unit count changing, relation endpoints were
still pointing to the edge of the service block as it was scaled before.  Now,
relation endpoints are updated as well.  Includes a test of this functionality.

R=gary.poster, bac
CC=
https://codereview.appspot.com/7141043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b