Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11052)

Issue 7138054: Avoid version check if make target != dist[file]

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by frankban
Modified:
11 years, 3 months ago
Reviewers:
mp+143693
Visibility:
Public.

Description

Avoid version check if make target != dist[file] Our Makefile stops the execution if the user: 1) tries to make a stable release and the latest version in CHANGES.yaml is "unreleased"; 2) tries to make a devel release and the latest version is not "unreleased". Now this check is only performed when the make target is dist or distfile, so that it is possible, e.g., to run tests on a stable release without defining FINAL=1. Updated process documentation. https://code.launchpad.net/~frankban/juju-gui/bug-1095663-test-final/+merge/143693 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Avoid version check if make target != dist[file] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Makefile View 2 chunks +5 lines, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M docs/process.rst View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
11 years, 3 months ago (2013-01-17 14:07:53 UTC) #1
gary.poster
Land as is. Thank you! Nice clean up. Gary https://codereview.appspot.com/7138054/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/7138054/diff/1/Makefile#newcode65 Makefile:65: ...
11 years, 3 months ago (2013-01-17 14:56:35 UTC) #2
teknico
Land as is, or with changes. :-) https://codereview.appspot.com/7138054/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/7138054/diff/1/Makefile#newcode66 Makefile:66: ifeq ($(ULTIMATE_VERSION), ...
11 years, 3 months ago (2013-01-17 15:53:46 UTC) #3
frankban
Thanks for the reviews! Landing. https://codereview.appspot.com/7138054/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/7138054/diff/1/Makefile#newcode66 Makefile:66: ifeq ($(ULTIMATE_VERSION), unreleased) On ...
11 years, 3 months ago (2013-01-17 15:58:11 UTC) #4
frankban
11 years, 3 months ago (2013-01-17 16:00:55 UTC) #5
*** Submitted:

Avoid version check if make target != dist[file]

Our Makefile stops the execution if the user:
1) tries to make a stable release and the latest
version in CHANGES.yaml is "unreleased";
2) tries to make a devel release and the latest
version is not "unreleased".

Now this check is only performed when the make
target is dist or distfile, so that it is 
possible, e.g., to run tests on a stable release
without defining FINAL=1.

Updated process documentation.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7138054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b