Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 7138044: environs/ec2: compress cloudinit data

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rog
Modified:
11 years, 4 months ago
Reviewers:
mp+143506
Visibility:
Public.

Description

environs/ec2: compress cloudinit data Also add trivial.Gzip and Gunzip to make it easy for other providers to do the same thing. https://code.launchpad.net/~rogpeppe/juju-core/193-compress-cloudinit/+merge/143506 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : cloudinit: add RenderCompressed #

Patch Set 3 : cloudinit: add RenderCompressed #

Patch Set 4 : environs/ec2: compress cloudinit data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -96 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M environs/ec2/ec2.go View 1 2 chunks +7 lines, -2 lines 0 comments Download
M environs/ec2/local_test.go View 1 3 chunks +9 lines, -4 lines 0 comments Download
D trivial/attempt_test.go View 1 1 chunk +0 lines, -39 lines 0 comments Download
D trivial/password_test.go View 1 1 chunk +0 lines, -51 lines 0 comments Download
M trivial/trivial.go View 1 2 chunks +27 lines, -0 lines 0 comments Download
A trivial/trivial_test.go View 1 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 4
niemeyer
https://codereview.appspot.com/7138044/diff/1/cloudinit/cloudinit.go File cloudinit/cloudinit.go (right): https://codereview.appspot.com/7138044/diff/1/cloudinit/cloudinit.go#newcode32 cloudinit/cloudinit.go:32: // Render returns the cloud-init configuration as gzip-compressed YAML ...
11 years, 4 months ago (2013-01-16 13:54:33 UTC) #1
rog
Please take a look.
11 years, 4 months ago (2013-01-16 14:31:50 UTC) #2
niemeyer
LGTM Please just fix the CL description during submit.
11 years, 4 months ago (2013-01-16 14:44:00 UTC) #3
rog
11 years, 4 months ago (2013-01-16 14:47:39 UTC) #4
*** Submitted:

environs/ec2: compress cloudinit data

Also add trivial.Gzip and Gunzip to make it
easy for other providers to do the same thing.

R=niemeyer
CC=
https://codereview.appspot.com/7138044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b