Issue 7137048: all: fix fmt mistakes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7137048: all: fix fmt mistakes

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+143672, niemeyer, TheMue

Visibility:
Public.

Description

all: fix fmt mistakes Also add a trailing "f" to some functions to make them amenable to go vet checking. https://code.launchpad.net/~rogpeppe/juju-core/196-fix-printf/+merge/143672 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: fix fmt mistakes #

Patch Set 3 : all: fix fmt mistakes #

Patch Set 4 : all: fix fmt mistakes #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -30 lines)			Patch
M	.lbox.check	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine.go	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	state/relation.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/service.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/settings.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	state/state.go	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	state/unit.go	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	worker/uniter/jujuc/server.go	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

*** Submitted: all: fix fmt mistakes Also add a trailing "f" to some functions to ...

11 years, 3 months ago (2013-01-17 12:27:47 UTC) #3

LGTM

Expand All Messages | Collapse All Messages