Issue 7137043: Fixed tests in trunk

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7137043: Fixed tests in trunk

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by frankban

Modified:
11 years, 3 months ago

Reviewers:
mp+143462

Visibility:
Public.

Description

Fixed tests in trunk Also removed the unused global variable noLogin. https://code.launchpad.net/~frankban/juju-gui/fix-tests-in-trunk/+merge/143462 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixed tests in trunk #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	app/views/login.js	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/index.html	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

frankban

*** Submitted: Fixed tests in trunk Also removed the unused global variable noLogin. R=teknico, bac ...

11 years, 3 months ago (2013-01-16 12:23:26 UTC) #4

Hi Nicola and Brad,
thanks for your reviews.

Expand All Messages | Collapse All Messages