Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(604)

Issue 7137043: Fixed tests in trunk

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by frankban
Modified:
8 years, 2 months ago
Reviewers:
mp+143462
Visibility:
Public.

Description

Fixed tests in trunk Also removed the unused global variable noLogin. https://code.launchpad.net/~frankban/juju-gui/fix-tests-in-trunk/+merge/143462 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixed tests in trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +5 lines, -2 lines 0 comments Download
M app/views/login.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/index.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
8 years, 2 months ago (2013-01-16 09:33:48 UTC) #1
teknico
Land as is. Nice fix and clean up, thanks.
8 years, 2 months ago (2013-01-16 09:59:29 UTC) #2
bac
Thanks Francesco. Land away.
8 years, 2 months ago (2013-01-16 12:09:59 UTC) #3
frankban
*** Submitted: Fixed tests in trunk Also removed the unused global variable noLogin. R=teknico, bac ...
8 years, 2 months ago (2013-01-16 12:23:26 UTC) #4
frankban
8 years, 2 months ago (2013-01-16 12:27:04 UTC) #5
Hi Nicola and Brad,
thanks for your reviews.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b