Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1656)

Issue 7135048: Do db migrations in charm

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by abentley-home
Modified:
11 years, 3 months ago
Reviewers:
hazmat, mp+143541
Visibility:
Public.

Description

Do db migrations in charm When adding a db relation, or when changing the revno, run bin/migrations upgrade. Since the db may not be initialized when the relation is created, use --init to initialize it if needed. Disable the ingest cronjob while upgrading the source tree, since that may migrate the db. Of course, this doesn't handle the case where the cronjob is already in progress, but it's a start. Also, set -x only after sourcing common, to avoid repetitive definition spam. https://code.launchpad.net/~abentley/charms/precise/charmworld/migrate/+merge/143541 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/config-changed View 3 chunks +8 lines, -6 lines 0 comments Download
M hooks/database-relation-changed View 2 chunks +4 lines, -2 lines 0 comments Download
M hooks/start View 1 chunk +6 lines, -4 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
abentley-home
Please take a look.
11 years, 3 months ago (2013-01-16 16:20:16 UTC) #1
hazmat
11 years, 3 months ago (2013-01-16 18:22:22 UTC) #2
On 2013/01/16 16:20:16, abentley wrote:
> Please take a look.

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b