Issue 7133072: environs/cloudinit: add state server ports

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7133072: environs/cloudinit: add state server ports

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+144685

Visibility:
Public.

Description

environs/cloudinit: add state server ports This means we don't need to pretend the API server address is also the address for the server to listen on. https://code.launchpad.net/~rogpeppe/juju-core/204-cloudinit-ports/+merge/144685 Requires: https://code.launchpad.net/~rogpeppe/juju-core/203-api-multi-addr/+merge/144534 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/cloudinit: add state server ports #

Patch Set 3 : environs/cloudinit: add state server ports #

Patch Set 4 : environs/cloudinit: add state server ports #

Patch Set 5 : environs/cloudinit: add state server ports #

Total comments: 3

Patch Set 6 : environs/cloudinit: add state server ports #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -21 lines)			Patch
A	[revision details]	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	1 3	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	environs/agent/agent.go	View	3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	environs/agent/agent_test.go	View	3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	1 2 3 4 5	7 chunks	+23 lines, -13 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View	1 2 3 4 5	5 chunks	+18 lines, -6 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/openstack/provider.go	View	1 2 3 4 5	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

The change to have the ports configurable seems okay, but it shouldn't be random. https://codereview.appspot.com/7133072/diff/7001/cmd/jujud/machine_test.go ...

11 years, 3 months ago (2013-01-24 13:42:09 UTC) #2

rog

11 years, 3 months ago (2013-01-24 14:13:56 UTC) #4

*** Submitted:

environs/cloudinit: add state server ports

This means we don't need to pretend the API server
address is also the address for the server to listen on.

R=niemeyer
CC=
https://codereview.appspot.com/7133072

https://codereview.appspot.com/7133072/diff/7001/cmd/jujud/machine_test.go
File cmd/jujud/machine_test.go (right):

https://codereview.appspot.com/7133072/diff/7001/cmd/jujud/machine_test.go#ne...
cmd/jujud/machine_test.go:205: port := testing.FindTCPPort()
On 2013/01/24 13:42:10, niemeyer wrote:
> This doesn't look right. The port the API responds in must be predictable,
> otherwise external clients will not be able to connect.

as discussed online, this is for the tests only.

Expand All Messages | Collapse All Messages