Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5109)

Issue 7133064: code review 7133064: src: add race.bat (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by minux1
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev, dave_cheney.net, brainman
Visibility:
Public.

Description

src: add race.bat

Patch Set 1 #

Patch Set 2 : diff -r 5b5399bc3335 https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r 5b5399bc3335 https://code.google.com/p/go #

Patch Set 4 : diff -r 5b5399bc3335 https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r 6ea4af4a1d5e https://code.google.com/p/go #

Patch Set 6 : diff -r 036190b86798 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A src/race.bat View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Looks pretty good to me. https://codereview.appspot.com/7133064/diff/2001/src/race.bat File src/race.bat (right): https://codereview.appspot.com/7133064/diff/2001/src/race.bat#newcode5 src/race.bat:5: :: TODO: explain what ...
11 years, 3 months ago (2013-01-23 10:59:01 UTC) #1
minux1
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2013-01-23 11:09:42 UTC) #2
dave_cheney.net
Ping, i've just submitted 7179052.
11 years, 3 months ago (2013-01-28 10:08:48 UTC) #3
brainman
LGTM Thank you. I even found a new problem (http://code.google.com/p/go/issues/detail?id=4721) :-) Alex https://codereview.appspot.com/7133064/diff/9001/src/race.bat File src/race.bat ...
11 years, 3 months ago (2013-01-29 00:34:32 UTC) #4
dave_cheney.net
ping.
11 years, 3 months ago (2013-02-02 10:11:22 UTC) #5
minux1
11 years, 3 months ago (2013-02-02 16:49:51 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=126f492983f7 ***

src: add race.bat

R=golang-dev, dave, alex.brainman
CC=golang-dev
https://codereview.appspot.com/7133064
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b