Issue 7133063: juju: add APIConn

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+144452

Visibility:
Public.

Description

juju: add APIConn Also start the API server in tests and make APIConn available in testing.JujuConnSuite. https://code.launchpad.net/~rogpeppe/juju-core/202-environs-apiinfo/+merge/144452 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: add APIConn #

Patch Set 3 : juju: add APIConn #

Total comments: 4

Patch Set 4 : juju: add APIConn #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -82 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/ssh_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/juju/status_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/dummy/environs.go	View		8 chunks	+48 lines, -14 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1 2 3	5 chunks	+21 lines, -13 lines	0 comments	Download
M	environs/ec2/live_test.go	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	environs/ec2/local_test.go	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	environs/interface.go	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 2 3	5 chunks	+6 lines, -6 lines	0 comments	Download
M	environs/jujutest/tests.go	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	environs/openstack/provider.go	View	1 2 3	3 chunks	+3 lines, -2 lines	0 comments	Download
A	juju/api.go	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	juju/conn.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	juju/conn_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	juju/testing/conn.go	View		5 chunks	+35 lines, -12 lines	0 comments	Download
M	worker/firewaller/firewaller_test.go	View		4 chunks	+4 lines, -13 lines	0 comments	Download
M	worker/provisioner/provisioner.go	View		4 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM.. very good stuff. https://codereview.appspot.com/7133063/diff/4001/environs/dummy/environs.go File environs/dummy/environs.go (right): https://codereview.appspot.com/7133063/diff/4001/environs/dummy/environs.go#newcode454 environs/dummy/environs.go:454: e.state.apiAddr = fmt.Sprintf("localhost:%d", testing.FindTCPPort()) The ...

11 years, 3 months ago (2013-01-24 13:31:23 UTC) #2

rog

11 years, 3 months ago (2013-01-24 14:01:25 UTC) #3

*** Submitted:

juju: add APIConn

Also start the API server in tests and make APIConn
available in testing.JujuConnSuite.

R=niemeyer
CC=
https://codereview.appspot.com/7133063

https://codereview.appspot.com/7133063/diff/4001/environs/dummy/environs.go
File environs/dummy/environs.go (right):

https://codereview.appspot.com/7133063/diff/4001/environs/dummy/environs.go#n...
environs/dummy/environs.go:454: e.state.apiAddr = fmt.Sprintf("localhost:%d",
testing.FindTCPPort())
On 2013/01/24 13:31:23, niemeyer wrote:
> The API server should have a well defined port. We'll need to offer a
> predictable location to outsiders.

agreed. but for the tests, i think that, as with the mongo server, it's good to
use a port chosen for the occasion 
so that concurrent tests don't clash.

https://codereview.appspot.com/7133063/diff/4001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/7133063/diff/4001/environs/ec2/ec2.go#newcode24
environs/ec2/ec2.go:24: const apiPort = 37018
On 2013/01/24 13:31:23, niemeyer wrote:
> It'd be best to pick a separate range. MongoDB has several features that end
up
> landing in nearby ports.

Done.

Expand All Messages | Collapse All Messages