Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(171)

Issue 7133059: code review 7133059: cmd/gc: fix handling of struct padding in hash/eq. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by remyoudompheng
Modified:
9 years, 10 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/gc: fix handling of struct padding in hash/eq. The test case of issue 4585 was not passing due to miscalculation of memequal args, and the previous fix does not handle padding at the end of a struct. Handling of padding at end of structs also fixes the case of [n]T where T is such a padded struct. Fixes issue 4585. (again)

Patch Set 1 #

Patch Set 2 : diff -r 7059eeacbfba https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7059eeacbfba https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0264b73d26bf https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -16 lines) Patch
M src/cmd/gc/subr.c View 1 7 chunks +18 lines, -16 lines 0 comments Download
M test/fixedbugs/issue4585.go View 1 2 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 10 months ago (2013-01-18 18:14:23 UTC) #1
rsc
LGTM Very nice.
9 years, 10 months ago (2013-01-18 19:10:13 UTC) #2
remyoudompheng
9 years, 10 months ago (2013-01-18 21:42:14 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=b555da941249 ***

cmd/gc: fix handling of struct padding in hash/eq.

The test case of issue 4585 was not passing due to
miscalculation of memequal args, and the previous fix
does not handle padding at the end of a struct.

Handling of padding at end of structs also fixes the case
of [n]T where T is such a padded struct.

Fixes issue 4585.
(again)

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7133059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b