Issue 7132057: code review 7132057: cmd/go: diagnose un-bootstrapped runtime

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7132057: code review 7132057: cmd/go: diagnose un-bootstrapped runtime (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Description

cmd/go: diagnose un-bootstrapped runtime Fixes issue 4665.

Patch Set 2 : diff -r 1b57fb106d8d https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 6519eef2c815 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6519eef2c815 https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	src/cmd/go/build.go	View	1 2 3	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2013-01-18 21:05:34 UTC) #1

minux1

LGTM. https://codereview.appspot.com/7132057/diff/2001/src/cmd/go/build.go File src/cmd/go/build.go (right): https://codereview.appspot.com/7132057/diff/2001/src/cmd/go/build.go#newcode683 src/cmd/go/build.go:683: !hasString(a.p.GoFiles, "zasm_"+buildContext.GOOS+"_"+buildContext.GOARCH+".go") { i think you mean zruntime_defs_$GOOS_$GOARCH.go, ...

12 years, 3 months ago (2013-01-18 21:11:12 UTC) #2

minux1

On Sat, Jan 19, 2013 at 5:20 AM, Russ Cox <rsc@golang.org> wrote: > Actually I ...

12 years, 3 months ago (2013-01-18 21:23:36 UTC) #4

rsc

12 years, 3 months ago (2013-01-18 21:24:12 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=6ba201b58519 ***

cmd/go: diagnose un-bootstrapped runtime

Fixes issue 4665.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7132057

Expand All Messages | Collapse All Messages