Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
*** Submitted as https://code.google.com/p/go/source/detail?r=dff6e212f5cb *** testing: allow examples to pass (fix build) R=golang-dev CC=golang-dev https://codereview.appspot.com/7132050
LGTM On Thu, Jan 17, 2013 at 5:23 PM, <adg@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: > Hello golang-dev@googlegroups.com, > > I'd like you to review this change to > https://code.google.com/p/go > > > Description: > testing: allow examples to pass (fix build) > > Please review this at https://codereview.appspot.**com/7132050/<https://codereview.appspot.com/7132... > > Affected files: > M src/pkg/testing/example.go > > > Index: src/pkg/testing/example.go > ==============================**==============================**======= > --- a/src/pkg/testing/example.go > +++ b/src/pkg/testing/example.go > @@ -67,6 +67,7 @@ > }() > > start := time.Now() > + ok = true > > // Clean up in a deferred call so we can recover if the example > panics. > defer func() { > @@ -84,6 +85,7 @@ > } > if fail != "" || err != nil { > fmt.Printf("--- FAIL: %s (%v)\n%s", eg.Name, d, > fail) > + ok = false > } else if *chatty { > fmt.Printf("--- PASS: %s (%v)\n", eg.Name, d) > } > > >