Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(202)

Issue 7132044: code review 7132044: cmd/godoc: handle file name arguments better

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by adg
Modified:
8 years, 7 months ago
Reviewers:
minux1, rsc
CC:
golang-codereviews
Visibility:
Public.

Description

cmd/godoc: handle file name arguments better This change prints a warning/suggestion if the user refers to the directory "foo" when it should be the relative path "./foo". Furthermore, it discovers if "./foo" resides under an GOPATH or GOROOT and displays the correct import path. For example, cd $GOROOT/src/pkg/archive godoc ./zip will display the docs for "archive/zip" with the correct import path. Fixes issue 4330.

Patch Set 1 #

Patch Set 2 : diff -r e379fdfeb87e https://code.google.com/p/go #

Patch Set 3 : diff -r e379fdfeb87e https://code.google.com/p/go #

Patch Set 4 : diff -r a55bd9f21507 https://code.google.com/p/go #

Patch Set 5 : diff -r a55bd9f21507 https://code.google.com/p/go #

Patch Set 6 : diff -r dff6e212f5cb https://code.google.com/p/go #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -46 lines) Patch
M src/cmd/godoc/doc.go View 1 chunk +10 lines, -5 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 2 3 4 5 2 chunks +14 lines, -5 lines 2 comments Download
M src/cmd/godoc/main.go View 1 2 3 4 5 4 chunks +48 lines, -36 lines 3 comments Download

Messages

Total messages: 12
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2013-01-16 09:51:36 UTC) #1
minux1
the behavior for commands seems to be inconsistent with that of normal packages. try this: ...
9 years, 8 months ago (2013-01-16 10:58:47 UTC) #2
adg
On 16 January 2013 21:58, minux <minux.ma@gmail.com> wrote: > the behavior for commands seems to ...
9 years, 8 months ago (2013-01-17 03:15:25 UTC) #3
adg
PTAL This now depends on https://codereview.appspot.com/7129048
9 years, 8 months ago (2013-01-17 05:28:00 UTC) #4
rsc
I am not sure this is a good idea. I am uncomfortable with the ambiguity ...
9 years, 8 months ago (2013-01-17 14:12:36 UTC) #5
adg
On 18 January 2013 01:12, Russ Cox <rsc@golang.org> wrote: > What if there is a ...
9 years, 8 months ago (2013-01-17 23:25:20 UTC) #6
rsc
> You get the standard library's math. The order of precedence for > non-absolute paths ...
9 years, 8 months ago (2013-01-18 16:28:44 UTC) #7
adg
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2013-01-18 23:05:49 UTC) #8
rsc
I am happy with where this is going, just want to try to clean up ...
9 years, 8 months ago (2013-01-22 21:46:20 UTC) #9
adg
https://codereview.appspot.com/7132044/diff/5004/src/cmd/godoc/godoc.go File src/cmd/godoc/godoc.go (right): https://codereview.appspot.com/7132044/diff/5004/src/cmd/godoc/godoc.go#newcode1052 src/cmd/godoc/godoc.go:1052: // then it is not usable as command docs. ...
9 years, 8 months ago (2013-01-23 05:58:29 UTC) #10
gobot
Replacing golang-dev with golang-codereviews.
8 years, 9 months ago (2013-12-20 16:21:40 UTC) #11
rsc
8 years, 7 months ago (2014-03-05 19:34:03 UTC) #12
R=close

these files don't exist anymore
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b