Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2613)

Issue 7131057: Treat return statements in loops as loop discontinuities. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by apatrick1
Modified:
11 years, 3 months ago
Reviewers:
kbr1, dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Treat return statements in loops as loop discontinuities. This is so that texture2D is converted to texture2DLod in loops with return statements. HLSL does not seem to allow gradient operations in loops with return statements. It considers them to be breaks. Committed: https://code.google.com/p/angleproject/source/detail?r=1722

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M src/common/version.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/DetectDiscontinuity.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/DetectDiscontinuity.cpp View 1 2 3 2 chunks +21 lines, -1 line 0 comments Download
M src/compiler/OutputHLSL.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
apatrick1
PTAL. This fixes the issue that lead me to try transforming all texture2D calls to ...
11 years, 3 months ago (2013-01-18 19:52:26 UTC) #1
kbr1
LGTM
11 years, 3 months ago (2013-01-18 21:10:02 UTC) #2
dgkoch
+nicolas
11 years, 3 months ago (2013-01-21 22:23:42 UTC) #3
kbr1
A note to mention that this fixes a problem with a customer application. Your review ...
11 years, 3 months ago (2013-01-22 20:47:37 UTC) #4
nicolas
11 years, 3 months ago (2013-01-22 20:58:38 UTC) #5
Looks excellent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b