Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 7131052: code review 7131052: encoding/xml: fix decoding of attributes in to pointer ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by kisielk
Modified:
9 years, 2 months ago
Reviewers:
rsc
CC:
anacrolix, rsc, golang-dev
Visibility:
Public.

Description

encoding/xml: fix decoding of attributes in to pointer fields. Fixes issue 3719.

Patch Set 1 #

Patch Set 2 : diff -r a55bd9f21507 https://code.google.com/p/go #

Patch Set 3 : diff -r a55bd9f21507 https://code.google.com/p/go #

Patch Set 4 : diff -r a55bd9f21507 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M src/pkg/encoding/xml/read.go View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/encoding/xml/read_test.go View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7
kisielk
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2013-01-17 07:22:12 UTC) #1
kisielk
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2013-01-17 16:02:43 UTC) #2
kisielk
Realized I wasn't actually subscribed to golang-dev so my mails were not going through. Trying ...
9 years, 8 months ago (2013-01-17 22:03:44 UTC) #3
anacrolix
On 2013/01/17 22:03:44, kamil.kisiel wrote: > Realized I wasn't actually subscribed to golang-dev so my ...
9 years, 8 months ago (2013-01-17 22:17:07 UTC) #4
rsc
LGTM
9 years, 8 months ago (2013-01-18 22:05:55 UTC) #5
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=e4df7915ab89 *** encoding/xml: fix decoding of attributes in to pointer fields. Fixes ...
9 years, 8 months ago (2013-01-18 22:07:38 UTC) #6
remyoudompheng
9 years, 2 months ago (2013-07-20 21:24:31 UTC) #7
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b