Issue 7131050: code review 7131050: exp/html: remove "INCOMPLETE" comment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7131050: code review 7131050: exp/html: remove "INCOMPLETE" comment (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by andybalholm

Modified:
11 years, 2 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

exp/html: remove "INCOMPLETE" comment I think that the parser is complete enough to take that warning out. It passes the test suite. There may be incompatible API changes, but being in the exp directory is warning enough for that.

Patch Set 1 #

Patch Set 2 : diff -r 9a3e56fe880c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9a3e56fe880c https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/pkg/exp/html/doc.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 3 months ago (2013-01-16 21:46:25 UTC) #1

nigeltao

LGTM. Yeah, there may be incompatible API changes (e.g. to support document.write in <script>), but ...

11 years, 3 months ago (2013-01-17 01:03:59 UTC) #2

nigeltao

*** Submitted as https://code.google.com/p/go/source/detail?r=e379fdfeb87e *** exp/html: remove "INCOMPLETE" comment I think that the parser is ...

11 years, 3 months ago (2013-01-17 01:06:22 UTC) #3

*** Abandoned ***

Expand All Messages | Collapse All Messages