Issue 7130051: Do not attempt login if ws doesn't exist.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7130051: Do not attempt login if ws doesn't exist.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bac

Modified:
11 years, 3 months ago

Reviewers:
mp+143602, hazmat

Visibility:
Public.

Description

Do not attempt login if ws doesn't exist. If the web socket is not connected the env login function should not proceed. https://code.launchpad.net/~bac/juju-gui/1099909/+merge/143602 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -3 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env.js	View	2 chunks	+4 lines, -2 lines	1 comment	Download
M	test/test_login.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hazmat

11 years, 3 months ago (2013-01-16 22:18:53 UTC) #2

idle thoughts

https://codereview.appspot.com/7130051/diff/1/app/store/env.js
File app/store/env.js (right):

https://codereview.appspot.com/7130051/diff/1/app/store/env.js#newcode299
app/store/env.js:299: }
this short circuits, but its unclear that it doesn't cause an unintended
consequence for a caller which expects a login. the caller should probably be
changed to do this on connected with an evt sub

incidentally we should probably check for some value on username / password.

Expand All Messages | Collapse All Messages