Issue 7130047: [PATCH] gcc/go/gospec.c: fix static linking of Go programs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7130047: [PATCH] gcc/go/gospec.c: fix static linking of Go programs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by minux1

Modified:
11 years, 3 months ago

Reviewers:
iant

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn://gcc.gnu.org/svn/gcc/trunk/

Visibility:
Public.

Description

2013-01-16 Shenghou Ma <minux.ma@gmail.com> * gospec.c: pass -u pthread_create to linker when static linking.

Patch Set 2 : enlarged num_args and reformatted the comment #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	gcc/go/gospec.c	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

LGTM https://codereview.appspot.com/7130047/diff/1/gcc/go/gospec.c File gcc/go/gospec.c (right): https://codereview.appspot.com/7130047/diff/1/gcc/go/gospec.c#newcode230 gcc/go/gospec.c:230: num_args = argc + need_math + shared_libgcc + ...

11 years, 3 months ago (2013-01-16 15:42:00 UTC) #1

iant

11 years, 3 months ago (2013-01-16 15:42:00 UTC) #2

Approved and applied.

Thanks!

Expand All Messages | Collapse All Messages