Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(591)

Issue 7130045: Autoset version number in project docs

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by teknico
Modified:
8 years, 2 months ago
Reviewers:
mp+143489, benji, gary.poster
Visibility:
Public.

Description

Autoset version number in project docs Set the "version" and "release" values in docs/conf.py from the current version number in CHANGES.yaml . https://code.launchpad.net/~teknico/juju-gui/vernum-from-yaml-to-docs/+merge/143489 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 14

Patch Set 2 : Autoset version number in project docs #

Patch Set 3 : Autoset version number in project docs #

Patch Set 4 : Autoset version number in project docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -25 lines) Patch
M HACKING View 4 chunks +20 lines, -12 lines 0 comments Download
M README View 2 chunks +5 lines, -4 lines 0 comments Download
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M docs/conf.py View 1 2 2 chunks +61 lines, -4 lines 0 comments Download
M docs/index.rst View 1 chunk +2 lines, -2 lines 0 comments Download
M docs/process.rst View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 11
teknico
Please take a look.
8 years, 2 months ago (2013-01-16 11:58:12 UTC) #1
frankban
Land with changes. Another good improvement to our doc infrastructure Nicola, thank you! https://codereview.appspot.com/7130045/diff/1/docs/conf.py File ...
8 years, 2 months ago (2013-01-16 12:45:23 UTC) #2
teknico
https://codereview.appspot.com/7130045/diff/1/docs/conf.py File docs/conf.py (right): https://codereview.appspot.com/7130045/diff/1/docs/conf.py#newcode63 docs/conf.py:63: Get (version, release) from a yaml-formatted changes file. frankban ...
8 years, 2 months ago (2013-01-16 13:17:28 UTC) #3
teknico
Please take a look.
8 years, 2 months ago (2013-01-16 13:18:08 UTC) #4
gary.poster
Looks good to me Nicola, thank you. Land with frankban's changes (though you might be ...
8 years, 2 months ago (2013-01-16 13:21:15 UTC) #5
teknico
https://codereview.appspot.com/7130045/diff/1/docs/conf.py File docs/conf.py (right): https://codereview.appspot.com/7130045/diff/1/docs/conf.py#newcode82 docs/conf.py:82: release = changes[0].keys()[0] gary.poster wrote: > If you do ...
8 years, 2 months ago (2013-01-16 14:53:08 UTC) #6
teknico
teknico wrote: > Given the shortness and the difference in implementation, it > does not ...
8 years, 2 months ago (2013-01-16 14:55:54 UTC) #7
teknico
Please take a look.
8 years, 2 months ago (2013-01-16 14:56:53 UTC) #8
teknico
*** Submitted: Autoset version number in project docs Set the "version" and "release" values in ...
8 years, 2 months ago (2013-01-16 15:00:54 UTC) #9
gary.poster
On 2013/01/16 14:55:54, teknico wrote: > teknico wrote: > > Given the shortness and the ...
8 years, 2 months ago (2013-01-16 15:01:16 UTC) #10
benji
8 years, 2 months ago (2013-01-16 15:12:11 UTC) #11
https://codereview.appspot.com/7130045/diff/1/docs/conf.py
File docs/conf.py (right):

https://codereview.appspot.com/7130045/diff/1/docs/conf.py#newcode82
docs/conf.py:82: release = changes[0].keys()[0]
On 2013/01/16 13:21:16, gary.poster wrote:
> On 2013/01/16 12:45:23, frankban wrote:
> > As we discussed on IRC, for trunk releases the release here will always be
> > "unreleased".
> > It could be great to calculate the release using `bzr revno` as already done
> by
> > the `make distfile` command. What do you think? I think this could be
tackled
> in
> > another card if necessary.
> If you do this (now or later) it might be nice to have a standalone Python
file
> that generates the version number that the Makefile and this code can use.

Another option for unification would be to have a makefile target that reports
the calculated version number.  This code could then get it from there.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b