Issue 7129046: code review 7129046: go/types: correct result type for append (bug fix)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7129046: code review 7129046: go/types: correct result type for append (bug fix) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by gri

Modified:
12 years, 2 months ago

Reviewers:

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go/types: correct result type for append (bug fix) Rewrote existing code to prevent similar mistakes.

Patch Set 1 #

Patch Set 2 : diff -r 9a3e56fe880c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9a3e56fe880c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9a3e56fe880c https://code.google.com/p/go/ #

Patch Set 5 : diff -r 9a3e56fe880c https://code.google.com/p/go/ #

Patch Set 6 : diff -r 9a3e56fe880c https://code.google.com/p/go/ #

Patch Set 7 : diff -r 39f95f46bdac https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -25 lines)			Patch
	M	src/pkg/go/types/builtins.go	View	1 2 3 4	11 chunks	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-01-16 21:00:00 UTC) #1

adonovan

LGTM Thanks for fixing this. You should probably be resting though. :)

12 years, 2 months ago (2013-01-16 21:16:46 UTC) #2

gri

12 years, 2 months ago (2013-01-16 23:08:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=3914255bcf5f ***

go/types: correct result type for append (bug fix)

Rewrote existing code to prevent similar mistakes.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/7129046

Expand All Messages | Collapse All Messages