Issue 7128047: environs/agent: add server cert and key

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7128047: environs/agent: add server cert and key

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+143666

Visibility:
Public.

Description

environs/agent: add server cert and key https://code.launchpad.net/~rogpeppe/juju-core/194-agent-server-cert/+merge/143666 Requires: https://code.launchpad.net/~rogpeppe/juju-core/188-agent-mongo-addr/+merge/143286 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/agent: add server cert and key #

Patch Set 3 : environs/agent: add server cert and key #

Total comments: 4

Patch Set 4 : environs/agent: add server cert and key #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -22 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/agent/agent.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	environs/agent/agent_test.go	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	environs/cloudinit/cloudinit.go	View		2 chunks	+6 lines, -14 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View		2 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

LGTM, assuming things still work for real when using juju against Amazon. https://codereview.appspot.com/7128047/diff/1006/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go ...

11 years, 3 months ago (2013-01-18 14:48:27 UTC) #3

rog

11 years, 3 months ago (2013-01-18 15:16:45 UTC) #4

*** Submitted:

environs/agent: add server cert and key

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/7128047

https://codereview.appspot.com/7128047/diff/1006/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (left):

https://codereview.appspot.com/7128047/diff/1006/environs/cloudinit/cloudinit...
environs/cloudinit/cloudinit.go:120: addFile(c, serverKey,
string(cfg.StateServerKey), 0600)
On 2013/01/18 14:48:27, niemeyer wrote:
> Is it okay to drop these files?

yes - i added them in the expectation that they'd be used by jujud, but that was
before agent.Conf emerged.

https://codereview.appspot.com/7128047/diff/1006/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/7128047/diff/1006/environs/cloudinit/cloudinit...
environs/cloudinit/cloudinit.go:173: StateInfo:       *cfg.StateInfo,
On 2013/01/18 14:48:27, niemeyer wrote:
> Why do the structures have different representations for the same setting? 

that's a good question. for some reason i thought it was nicer to use StateInfo
by value in agent.Conf, but i can't see a good reason now :-)

will change it in a future CL.

Expand All Messages | Collapse All Messages