Issue 7124063: code review 7124063: encoding/xml: simplify copyValue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7124063: code review 7124063: encoding/xml: simplify copyValue (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by rsc

Modified:
12 years, 5 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

encoding/xml: simplify copyValue Delete various complications left over from an earlier reflect API.

Patch Set 1 #

Patch Set 2 : diff -r e4df7915ab89 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e4df7915ab89 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6b1a1bb92ac2 https://go.googlecode.com/hg/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -38 lines)			Patch
	M	src/pkg/encoding/xml/read.go	View	1	1 chunk	+21 lines, -38 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 6 months ago (2013-01-18 22:10:47 UTC) #1

rsc

12 years, 5 months ago (2013-01-22 22:05:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ea98b711a89b ***

encoding/xml: simplify copyValue

Delete various complications left over from an earlier reflect API.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7124063

Expand All Messages | Collapse All Messages