Issue 7124062: environs/agent: use *StateInfo and *APIInfo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7124062: environs/agent: use StateInfo and APIInfo

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+143912

Visibility:
Public.

Description

environs/agent: use *StateInfo and *APIInfo Since either or both might be set in the future, we add an EntityName field to APIInfo too, and use whichever is set, requiring them to match if both are specified. https://code.launchpad.net/~rogpeppe/juju-core/198-agent-stateinfo-ptr/+merge/143912 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/agent: use StateInfo and APIInfo #

Total comments: 2

Patch Set 3 : environs/agent: use StateInfo and APIInfo #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -65 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/jujud/bootstrap.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/machine_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/unit_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	environs/agent/agent.go	View	1 2	7 chunks	+42 lines, -19 lines	0 comments	Download
M	environs/agent/agent_test.go	View	1 2	15 chunks	+87 lines, -34 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	state/api/client.go	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	worker/deployer/simple.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	worker/deployer/simple_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/7124062/diff/2001/environs/agent/agent.go File environs/agent/agent.go (right): https://codereview.appspot.com/7124062/diff/2001/environs/agent/agent.go#newcode106 environs/agent/agent.go:106: return requiredError("state info and API info") s/and/or/? Not ...

11 years, 3 months ago (2013-01-18 16:54:09 UTC) #2

rog

11 years, 3 months ago (2013-01-21 10:32:50 UTC) #3

*** Submitted:

environs/agent: use *StateInfo and *APIInfo

Since either or both might be set in the future,
we add an EntityName field to APIInfo too,
and use whichever is set, requiring them to match
if both are specified.

R=niemeyer
CC=
https://codereview.appspot.com/7124062

Expand All Messages | Collapse All Messages