Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(364)

Issue 7109043: code review 7109043: net/http: fix racy test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by bradfitz
Modified:
9 years, 8 months ago
Reviewers:
CC:
golang-dev, iant
Visibility:
Public.

Description

net/http: fix racy test We need to wait for the handler to actually finish running, not almost be done running. This was always a bug, but now that handler output is buffered it shows up easily on GOMAXPROCS >1 systems.

Patch Set 1 #

Patch Set 2 : diff -r e55f615005ba https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e55f615005ba https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e55f615005ba https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/pkg/net/http/serve_test.go View 1 2 3 5 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 8 months ago (2013-01-15 15:07:13 UTC) #1
iant
LGTM Perhaps you could also use this in TestServerUnreadRequestBodyLittle and TestServerUnreadRequestBodyLarge
9 years, 8 months ago (2013-01-15 15:26:53 UTC) #2
bradfitz
9 years, 8 months ago (2013-01-15 17:13:13 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=9a3e56fe880c ***

net/http: fix racy test

We need to wait for the handler to actually finish running,
not almost be done running.

This was always a bug, but now that handler output is buffered
it shows up easily on GOMAXPROCS >1 systems.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7109043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b