Issue 7109043: code review 7109043: net/http: fix racy test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7109043: code review 7109043: net/http: fix racy test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bradfitz

Modified:
11 years, 3 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

net/http: fix racy test We need to wait for the handler to actually finish running, not almost be done running. This was always a bug, but now that handler output is buffered it shows up easily on GOMAXPROCS >1 systems.

Patch Set 1 #

Patch Set 2 : diff -r e55f615005ba https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e55f615005ba https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e55f615005ba https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/pkg/net/http/serve_test.go	View	1 2 3	5 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 3 months ago (2013-01-15 15:07:13 UTC) #1

iant

LGTM Perhaps you could also use this in TestServerUnreadRequestBodyLittle and TestServerUnreadRequestBodyLarge

11 years, 3 months ago (2013-01-15 15:26:53 UTC) #2

bradfitz

11 years, 3 months ago (2013-01-15 17:13:13 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9a3e56fe880c ***

net/http: fix racy test

We need to wait for the handler to actually finish running,
not almost be done running.

This was always a bug, but now that handler output is buffered
it shows up easily on GOMAXPROCS >1 systems.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7109043

Expand All Messages | Collapse All Messages