Issue 7107043: code review 7107043: go/types: callback for *ast.Ident -> Object mapping

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7107043: code review 7107043: go/types: callback for *ast.Ident -> Object mapping (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by gri

Modified:
12 years, 6 months ago

Reviewers:

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go/types: callback for *ast.Ident -> Object mapping Also re-enabled resolver test.

Patch Set 2 : diff -r d3ecdec9e184 https://code.google.com/p/go #

Patch Set 3 : diff -r d3ecdec9e184 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 2b24ee0f7b5e https://code.google.com/p/go #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -90 lines)			Patch
M	src/pkg/go/types/api.go	View	1 2 3	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/pkg/go/types/check.go	View	1	5 chunks	+20 lines, -6 lines	0 comments	Download
M	src/pkg/go/types/expr.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/go/types/resolve.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/types/resolver_test.go	View	1	4 chunks	+37 lines, -79 lines	0 comments	Download
M	src/pkg/go/types/stmt.go	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 6 months ago (2013-01-13 23:18:02 UTC) #1

adonovan

LGTM https://codereview.appspot.com/7107043/diff/5001/src/pkg/go/types/api.go File src/pkg/go/types/api.go (right): https://codereview.appspot.com/7107043/diff/5001/src/pkg/go/types/api.go#newcode28 src/pkg/go/types/api.go:28: // If Ident is not nil, is is ...

12 years, 6 months ago (2013-01-14 17:35:14 UTC) #2

gri

12 years, 6 months ago (2013-01-14 17:43:31 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=c6a4b0fb079b ***

go/types: callback for *ast.Ident -> Object mapping

Also re-enabled resolver test.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/7107043

Expand All Messages | Collapse All Messages