Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(105)

Issue 7106052: all: remove redundant Dying methods

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by rog
Modified:
11 years, 3 months ago
Reviewers:
mp+143364, fwereade
Visibility:
Public.

Description

all: remove redundant Dying methods Also change Dying methods to Dead methods where appropriate (they were used as if they were Dead methods in all cases). https://code.launchpad.net/~rogpeppe/juju-core/192-kill-dying/+merge/143364 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: remove redundant Dying methods #

Patch Set 3 : all: remove redundant Dying methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -20 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M worker/firewaller/firewaller.go View 1 chunk +0 lines, -5 lines 0 comments Download
M worker/provisioner/provisioner.go View 1 chunk +0 lines, -5 lines 0 comments Download
M worker/uniter/filter.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/uniter/filter_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/modes.go View 4 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/uniter.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M worker/uniter/uniter_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
11 years, 3 months ago (2013-01-15 17:11:52 UTC) #1
rog
Please take a look.
11 years, 3 months ago (2013-01-15 17:16:23 UTC) #2
rog
*** Submitted: all: remove redundant Dying methods Also change Dying methods to Dead methods where ...
11 years, 3 months ago (2013-01-15 17:46:23 UTC) #3
fwereade
11 years, 3 months ago (2013-01-16 08:28:31 UTC) #4
On 2013/01/15 17:46:23, rog wrote:
> *** Submitted:
> 
> all: remove redundant Dying methods
> 
> Also change Dying methods to Dead methods
> where appropriate (they were used as if they
> were Dead methods in all cases).
> 
> R=
> CC=
> https://codereview.appspot.com/7106052

LGTM, although I'm not even sure the Dead methods themselves quite deserve to
exist just for the convenience of the tests -- presumably we have future plans
for them? (and ty for fixing the <-u.Dying() nonsenses, not sure what I was
doing there.)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b